diff options
| author | Mark Felder <feld@feld.me> | 2021-06-08 16:19:12 -0500 |
|---|---|---|
| committer | Mark Felder <feld@feld.me> | 2021-06-08 16:19:12 -0500 |
| commit | d4ac9445cd485a4055f93360714923c3f64d9673 (patch) | |
| tree | 4bc0c3b2ceee38a73da8726b2ffb9679391c35f6 /lib | |
| parent | 5de65ce3e89ba2f229170ed18933c99e5caa8dff (diff) | |
| download | pleroma-d4ac9445cd485a4055f93360714923c3f64d9673.tar.gz | |
Twittercard metadata for images should also include dimensions if available
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/pleroma/web/metadata/providers/twitter_card.ex | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/lib/pleroma/web/metadata/providers/twitter_card.ex b/lib/pleroma/web/metadata/providers/twitter_card.ex index e28f832d4..bf6d4bcbe 100644 --- a/lib/pleroma/web/metadata/providers/twitter_card.ex +++ b/lib/pleroma/web/metadata/providers/twitter_card.ex @@ -55,7 +55,9 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do Enum.reduce(attachments, [], fn attachment, acc -> rendered_tags = Enum.reduce(attachment["url"], [], fn url, acc -> - # TODO: Add additional properties to objects when we have the data available. + height = url["height"] || 480 + width = url["width"] || 480 + case Utils.fetch_media_type(@media_types, url["mediaType"]) do "audio" -> [ @@ -73,16 +75,13 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do [ property: "twitter:player", content: Utils.attachment_url(url["href"]) - ], []} + ], []}, + {:meta, [property: "twitter:player:width", content: "#{width}"], []}, + {:meta, [property: "twitter:player:height", content: "#{height}"], []} | acc ] - # TODO: Need the true width and height values here or Twitter renders an iFrame with - # a bad aspect ratio "video" -> - height = url["height"] || 480 - width = url["width"] || 480 - [ {:meta, [property: "twitter:card", content: "player"], []}, {:meta, [property: "twitter:player", content: player_url(id)], []}, |