aboutsummaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2020-07-15Use `approval_required` in /api/v1/instanceAlex Gleason
2020-07-15Merge branch 'develop' into refactor/gun-pool-registryMark Felder
2020-07-15Merge branch 'develop' into refactor/notification_settingsMark Felder
2020-07-15Merge branch 'features/mrf-reasons' into 'develop'rinpatch
Add rejection reason to our MRFs See merge request pleroma/pleroma!2759
2020-07-15MastoAPI: fix & test giving MRF reject reasonsHaelwenn (lanodan) Monnier
2020-07-15ConnectionPool.Worker: do not stop with an error when there is a timeoutrinpatch
This produced error log messages about GenServer termination every time the connection was not open due to a timeout. Instead we stop with `{:shutdown, <gun_error>}` since shutting down when the connection can't be established is normal behavior.
2020-07-15Set a default timeout for Gun adapter timeouthref
2020-07-15host is now uselesshref
2020-07-15Simplify TLS optshref
- `verify_fun` is not useful now - use `customize_check_hostname` (OTP 20+ so OK) - `partial_chain` is useless as of OTP 21.1 (wasn't there, but hackney/.. uses it)
2020-07-15parentheses...href
2020-07-15Fix race in enforcer/reclaimer starthref
2020-07-15Ensure connections error get known by the callerhref
2020-07-15ConnectionPool.Worker: Open gun conn in continue instead of inithref
2020-07-15Connection Pool: fix LRFU implementation to not actually be LRUrinpatch
The numbers of the native time unit were so small the CRF was always 1, making it an LRU. This commit switches the time to miliseconds and changes the time delta multiplier to the one yielding mostly highest hit rates according to the paper
2020-07-15Request limiter setup: consider {:error, :existing} a successrinpatch
When the application restarts (which happens after certain config changes), the limiters are not destroyed, so `ConcurrentLimiter.new` will produce {:error, :existing}
2020-07-15FollowRedirects: Unconditionally release the connection if there is an errorrinpatch
There is no need for streaming the body if there is no body
2020-07-15Gun adapter helper: fix wildcard cert issues on OTP 23rinpatch
See https://bugs.erlang.org/browse/ERL-1260 for more info. The ssl match function is basically copied from mint, except that `:string.lowercase/1` was replaced by `:string.casefold`. It was a TODO in mint's code, so might as well do it since we don't need to support OTP <20. Closes #1834
2020-07-15Add documentation for new connection pool settings and remove somerinpatch
`:retry_timeout` and `:retry` got removed because reconnecting on failure is something the new pool intentionally doesn't do. `:max_overflow` had to go in favor of `:max_waiting`, I didn't reuse the key because the settings are very different in their behaviour. `:checkin_timeout` got removed in favor of `:connection_acquisition_wait`, I didn't reuse the key because the settings are somewhat different. I didn't do any migrations/deprecation warnings/changelog entries because these settings were never in stable.
2020-07-15Use erlang monotonic time for CRF calculationrinpatch
2020-07-15Adapter Helper: Use built-in ip address typerinpatch
2020-07-15HTTP: Implement max request limitsrinpatch
2020-07-15Use a custom pool-aware FollowRedirects middlewarerinpatch
2020-07-15Connection pool: fix connections being supervised by gun_suprinpatch
2020-07-15Connection pool: Add client death trackingrinpatch
While running this in production I noticed a number of ghost processes with all their clients dead before they released the connection, so let's track them to log it and remove them from clients
2020-07-15Connection pool: Fix a possible infinite recursion if the pool is exhaustedrinpatch
2020-07-15Connection pool: implement logging and telemetry eventsrinpatch
2020-07-15Connection Pool: register workers using :viarinpatch
2020-07-15Connection pool: Fix race conditions in limit enforcementrinpatch
Fixes race conditions in limit enforcement by putting worker processes in a DynamicSupervisor
2020-07-15Connection pool: check that there actually is a resultrinpatch
Sometimes connections died before being released to the pool, resulting in MatchErrors
2020-07-15Connection Pool: don't enforce pool limits if no new connection needs to be ↵rinpatch
opened
2020-07-15Refactor gun pooling and simplify adapter option insertionrinpatch
This patch refactors gun pooling to use Elixir process registry and simplifies adapter option insertion. Having the pool use process registry instead of a GenServer has a number of advantages: - Simpler code: the initial implementation adds about half the lines of code it deletes - Concurrency: unlike a GenServer, ETS-based registry can handle multiple checkout/checkin requests at the same time - Precise and easy idle connection clousure: current proposal for closing idle connections in the GenServer-based pool needs to filter through all connections once a minute and compare their last active time with closing time. With Elixir process registry this can be done by just using `Process.send_after`/`Process.cancel_timer` in the worker process. - Lower memory footprint: In my tests `gun-memory-leak` branch uses about 290mb on peak load (250 connections) and 235mb on idle (5-10 connections). Registry-based pool uses 210mb on idle and 240mb on peak load
2020-07-15Create Question: Add context field to createHaelwenn (lanodan) Monnier
2020-07-15{Answer,Question}Validator: Keep both actor and attributedTo for now but ↵Haelwenn (lanodan) Monnier
sync them
2020-07-15Fix attachments in pollsHaelwenn (lanodan) Monnier
2020-07-15Fixup for EctoType module moveHaelwenn (lanodan) Monnier
2020-07-15QuestionValidator: Use AttachmentValidatorHaelwenn (lanodan) Monnier
2020-07-15CreateGenericValidator: add expires_atHaelwenn (lanodan) Monnier
2020-07-15SideEffects: port ones from ActivityPub.do_create and ActivityPub.insertHaelwenn (lanodan) Monnier
2020-07-15question_validator: remove conversation fieldHaelwenn (lanodan) Monnier
2020-07-15question_validator: fix for mastodon poll expirationHaelwenn (lanodan) Monnier
Mastodon activities do not have a "closed" field, this could be seen on https://pouet.it/users/lanodan_tmp/statuses/104345126997708380 which runs Mastodon 3.1.4 (SDF runs 3.1.2)
2020-07-15create_question_validator: remove validate_recipients_matchHaelwenn (lanodan) Monnier
2020-07-15fetcher: Reinject Question through validatorHaelwenn (lanodan) Monnier
2020-07-15fetcher: more descriptive variable namesHaelwenn (lanodan) Monnier
2020-07-15Fix multiple-choice poll detectionHaelwenn (lanodan) Monnier
2020-07-15transmogrifier_test: test date, anyOf and oneOf completelyHaelwenn (lanodan) Monnier
2020-07-15QuestionOptionsValidator: inline schema for repliesHaelwenn (lanodan) Monnier
2020-07-15AnswerValidator: CreateHaelwenn (lanodan) Monnier
2020-07-15QuestionValidator: CreateHaelwenn (lanodan) Monnier
2020-07-14Email admins when a new unapproved account is up for reviewAlex Gleason
2020-07-14Merge remote-tracking branch 'upstream/develop' into by-approvalAlex Gleason