Merge branch '1439-favorite-deletion' into 'develop'

SideEffects test: Add test for favorite deletion.

Closes #1439

See merge request pleroma/pleroma!2508

1 files changed, 14 insertions, 2 deletions

diff --git a/test/web/activity_pub/side_effects_test.exs b/test/web/activity_pub/side_effects_test.exs
index aa3e40be1..6c5f8fc61 100644
--- a/test/web/activity_pub/side_effects_test.exs
+++ b/test/web/activity_pub/side_effects_test.exs
@@ -27,12 +27,22 @@ defmodule Pleroma.Web.ActivityPub.SideEffectsTest do
 
       {:ok, op} = CommonAPI.post(other_user, %{"status" => "big oof"})
       {:ok, post} = CommonAPI.post(user, %{"status" => "hey", "in_reply_to_id" => op})
+      {:ok, favorite} = CommonAPI.favorite(user, post.id)
       object = Object.normalize(post)
       {:ok, delete_data, _meta} = Builder.delete(user, object.data["id"])
       {:ok, delete_user_data, _meta} = Builder.delete(user, user.ap_id)
       {:ok, delete, _meta} = ActivityPub.persist(delete_data, local: true)
       {:ok, delete_user, _meta} = ActivityPub.persist(delete_user_data, local: true)
-      %{user: user, delete: delete, post: post, object: object, delete_user: delete_user, op: op}
+
+      %{
+        user: user,
+        delete: delete,
+        post: post,
+        object: object,
+        delete_user: delete_user,
+        op: op,
+        favorite: favorite
+      }
     end
 
     test "it handles object deletions", %{
@@ -40,7 +50,8 @@ defmodule Pleroma.Web.ActivityPub.SideEffectsTest do
       post: post,
       object: object,
       user: user,
-      op: op
+      op: op,
+      favorite: favorite
     } do
       with_mock Pleroma.Web.ActivityPub.ActivityPub, [:passthrough],
         stream_out: fn _ -> nil end,
@@ -55,6 +66,7 @@ defmodule Pleroma.Web.ActivityPub.SideEffectsTest do
       object = Object.get_by_id(object.id)
       assert object.data["type"] == "Tombstone"
       refute Activity.get_by_id(post.id)
+      refute Activity.get_by_id(favorite.id)
 
       user = User.get_by_id(user.id)
       assert user.note_count == 0