aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorWilliam Pitcock <nenolod@dereferenced.org>2018-11-01 07:29:12 +0000
committerWilliam Pitcock <nenolod@dereferenced.org>2018-11-01 07:29:12 +0000
commit2bf358d7b47f3c2dda91b0ac638b6a068fb40a4c (patch)
treec8e46d8d7bb5401077fc82568b666a502a3bea62 /lib
parentc4e43da63e03f66fd2feaa192c4d8192bbc3451c (diff)
downloadpleroma-2bf358d7b47f3c2dda91b0ac638b6a068fb40a4c.tar.gz
activitypub: use Object.delete() instead of mutating the database and cache directly
Diffstat (limited to 'lib')
-rw-r--r--lib/pleroma/web/activity_pub/activity_pub.ex3
-rw-r--r--lib/pleroma/web/common_api/common_api.ex3
2 files changed, 2 insertions, 4 deletions
diff --git a/lib/pleroma/web/activity_pub/activity_pub.ex b/lib/pleroma/web/activity_pub/activity_pub.ex
index 5a81f6fa2..48ae36ebd 100644
--- a/lib/pleroma/web/activity_pub/activity_pub.ex
+++ b/lib/pleroma/web/activity_pub/activity_pub.ex
@@ -273,8 +273,7 @@ defmodule Pleroma.Web.ActivityPub.ActivityPub do
"to" => [user.follower_address, "https://www.w3.org/ns/activitystreams#Public"]
}
- with Repo.delete(object),
- Repo.delete_all(Activity.all_non_create_by_object_ap_id_q(id)),
+ with Object.delete(object),
{:ok, activity} <- insert(data, local),
:ok <- maybe_federate(activity),
{:ok, _actor} <- User.decrease_note_count(user) do
diff --git a/lib/pleroma/web/common_api/common_api.ex b/lib/pleroma/web/common_api/common_api.ex
index 8607cb6b3..8f47bb127 100644
--- a/lib/pleroma/web/common_api/common_api.ex
+++ b/lib/pleroma/web/common_api/common_api.ex
@@ -9,8 +9,7 @@ defmodule Pleroma.Web.CommonAPI do
with %Activity{data: %{"object" => %{"id" => object_id}}} <- Repo.get(Activity, activity_id),
%Object{} = object <- Object.normalize(object_id),
true <- user.info["is_moderator"] || user.ap_id == object.data["actor"],
- {:ok, delete} <- ActivityPub.delete(object),
- {:ok, true} <- Cachex.del(:user_cache, "object:#{object_id}") do
+ {:ok, delete} <- ActivityPub.delete(object) do
{:ok, delete}
end
end