Remove unused ActivityRepresenter module.

3 files changed, 15 insertions, 145 deletions

diff --git a/lib/pleroma/web/twitter_api/representers/activity_representer.ex b/lib/pleroma/web/twitter_api/representers/activity_representer.ex
index c216c606e..9a4954de8 100644
--- a/lib/pleroma/web/twitter_api/representers/activity_representer.ex
+++ b/lib/pleroma/web/twitter_api/representers/activity_representer.ex
@@ -1,3 +1,5 @@
+# THIS MODULE IS DEPRECATED! DON'T USE IT!
+# USE THE Pleroma.Web.TwitterAPI.Views.ActivityView MODULE!
 defmodule Pleroma.Web.TwitterAPI.Representers.ActivityRepresenter do
   use Pleroma.Web.TwitterAPI.Representers.BaseRepresenter
   alias Pleroma.Web.TwitterAPI.Representers.ObjectRepresenter
diff --git a/lib/pleroma/web/twitter_api/twitter_api.ex b/lib/pleroma/web/twitter_api/twitter_api.ex
index b3b505be2..30362ef70 100644
--- a/lib/pleroma/web/twitter_api/twitter_api.ex
+++ b/lib/pleroma/web/twitter_api/twitter_api.ex
@@ -12,74 +12,6 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPI do
     CommonAPI.post(user, data)
   end
 
-  def fetch_friend_statuses(user, opts \\ %{}) do
-    opts =
-      opts
-      |> Map.put("blocking_user", user)
-      |> Map.put("user", user)
-      |> Map.put("type", ["Create", "Announce", "Follow", "Like"])
-
-    ActivityPub.fetch_activities([user.ap_id | user.following], opts)
-    |> activities_to_statuses(%{for: user})
-  end
-
-  def fetch_public_statuses(user, opts \\ %{}) do
-    opts =
-      opts
-      |> Map.put("local_only", true)
-      |> Map.put("blocking_user", user)
-      |> Map.put("type", ["Create", "Announce", "Follow"])
-
-    ActivityPub.fetch_public_activities(opts)
-    |> activities_to_statuses(%{for: user})
-  end
-
-  def fetch_public_and_external_statuses(user, opts \\ %{}) do
-    opts =
-      opts
-      |> Map.put("blocking_user", user)
-      |> Map.put("type", ["Create", "Announce", "Follow"])
-
-    ActivityPub.fetch_public_activities(opts)
-    |> activities_to_statuses(%{for: user})
-  end
-
-  def fetch_user_statuses(user, opts \\ %{}) do
-    opts =
-      opts
-      |> Map.put("type", ["Create"])
-
-    ActivityPub.fetch_public_activities(opts)
-    |> activities_to_statuses(%{for: user})
-  end
-
-  def fetch_mentions(user, opts \\ %{}) do
-    ActivityPub.fetch_activities([user.ap_id], opts)
-    |> activities_to_statuses(%{for: user})
-  end
-
-  def fetch_conversation(user, id) do
-    with context when is_binary(context) <- conversation_id_to_context(id),
-         activities <-
-           ActivityPub.fetch_activities_for_context(context, %{
-             "blocking_user" => user,
-             "user" => user
-           }),
-         statuses <- activities |> activities_to_statuses(%{for: user}) do
-      statuses
-    else
-      _e ->
-        []
-    end
-  end
-
-  def fetch_status(user, id) do
-    with %Activity{} = activity <- Repo.get(Activity, id),
-         true <- ActivityPub.visible_for_user?(activity, user) do
-      activity_to_status(activity, %{for: user})
-    end
-  end
-
   def follow(%User{} = follower, params) do
     with {:ok, %User{} = followed} <- get_user(params),
          {:ok, follower} <- User.follow(follower, followed),
@@ -127,25 +59,22 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPI do
 
   def repeat(%User{} = user, ap_id_or_id) do
     with {:ok, _announce, %{data: %{"id" => id}}} = CommonAPI.repeat(ap_id_or_id, user),
-         %Activity{} = activity <- Activity.get_create_activity_by_object_ap_id(id),
-         status <- activity_to_status(activity, %{for: user}) do
-      {:ok, status}
+         %Activity{} = activity <- Activity.get_create_activity_by_object_ap_id(id) do
+      {:ok, activity}
     end
   end
 
   def fav(%User{} = user, ap_id_or_id) do
     with {:ok, _announce, %{data: %{"id" => id}}} = CommonAPI.favorite(ap_id_or_id, user),
-         %Activity{} = activity <- Activity.get_create_activity_by_object_ap_id(id),
-         status <- activity_to_status(activity, %{for: user}) do
-      {:ok, status}
+         %Activity{} = activity <- Activity.get_create_activity_by_object_ap_id(id) do
+      {:ok, activity}
     end
   end
 
   def unfav(%User{} = user, ap_id_or_id) do
     with {:ok, %{data: %{"id" => id}}} = CommonAPI.unfavorite(ap_id_or_id, user),
-         %Activity{} = activity <- Activity.get_create_activity_by_object_ap_id(id),
-         status <- activity_to_status(activity, %{for: user}) do
-      {:ok, status}
+         %Activity{} = activity <- Activity.get_create_activity_by_object_ap_id(id) do
+      {:ok, activity}
     end
   end
 
@@ -279,63 +208,6 @@ defmodule Pleroma.Web.TwitterAPI.TwitterAPI do
     activities = Repo.all(q)
   end
 
-  defp activities_to_statuses(activities, opts) do
-    Enum.map(activities, fn activity ->
-      activity_to_status(activity, opts)
-    end)
-  end
-
-  # For likes, fetch the liked activity, too.
-  defp activity_to_status(%Activity{data: %{"type" => "Like"}} = activity, opts) do
-    actor = get_in(activity.data, ["actor"])
-    user = User.get_cached_by_ap_id(actor)
-    [liked_activity] = Activity.all_by_object_ap_id(activity.data["object"])
-
-    ActivityRepresenter.to_map(
-      activity,
-      Map.merge(opts, %{user: user, liked_activity: liked_activity})
-    )
-  end
-
-  # For announces, fetch the announced activity and the user.
-  defp activity_to_status(%Activity{data: %{"type" => "Announce"}} = activity, opts) do
-    actor = get_in(activity.data, ["actor"])
-    user = User.get_cached_by_ap_id(actor)
-    [announced_activity] = Activity.all_by_object_ap_id(activity.data["object"])
-    announced_actor = User.get_cached_by_ap_id(announced_activity.data["actor"])
-
-    ActivityRepresenter.to_map(
-      activity,
-      Map.merge(opts, %{users: [user, announced_actor], announced_activity: announced_activity})
-    )
-  end
-
-  defp activity_to_status(%Activity{data: %{"type" => "Delete"}} = activity, opts) do
-    actor = get_in(activity.data, ["actor"])
-    user = User.get_cached_by_ap_id(actor)
-    ActivityRepresenter.to_map(activity, Map.merge(opts, %{user: user}))
-  end
-
-  defp activity_to_status(activity, opts) do
-    actor = get_in(activity.data, ["actor"])
-    user = User.get_cached_by_ap_id(actor)
-    # mentioned_users = Repo.all(from user in User, where: user.ap_id in ^activity.data["to"])
-    mentioned_users =
-      Enum.map(activity.recipients || [], fn ap_id ->
-        if ap_id do
-          User.get_cached_by_ap_id(ap_id)
-        else
-          nil
-        end
-      end)
-      |> Enum.filter(& &1)
-
-    ActivityRepresenter.to_map(
-      activity,
-      Map.merge(opts, %{user: user, mentioned: mentioned_users})
-    )
-  end
-
   defp make_date do
     DateTime.utc_now() |> DateTime.to_iso8601()
   end
diff --git a/lib/pleroma/web/twitter_api/twitter_api_controller.ex b/lib/pleroma/web/twitter_api/twitter_api_controller.ex
index fb09deada..157e4826b 100644
--- a/lib/pleroma/web/twitter_api/twitter_api_controller.ex
+++ b/lib/pleroma/web/twitter_api/twitter_api_controller.ex
@@ -1,7 +1,6 @@
 defmodule Pleroma.Web.TwitterAPI.Controller do
   use Pleroma.Web, :controller
   alias Pleroma.Web.TwitterAPI.{TwitterAPI, UserView, ActivityView}
-  alias Pleroma.Web.TwitterAPI.Representers.ActivityRepresenter
   alias Pleroma.Web.CommonAPI
   alias Pleroma.{Repo, Activity, User}
   alias Pleroma.Web.ActivityPub.ActivityPub
@@ -152,10 +151,7 @@ defmodule Pleroma.Web.TwitterAPI.Controller do
 
   def delete_post(%{assigns: %{user: user}} = conn, %{"id" => id}) do
     with {:ok, delete} <- CommonAPI.delete(id, user) do
-      json = ActivityRepresenter.to_json(delete, %{user: user, for: user})
-
-      conn
-      |> json_reply(200, json)
+      render(conn, ActivityView, "activity.json", %{activity: delete, for: user})
     end
   end
 
@@ -216,20 +212,20 @@ defmodule Pleroma.Web.TwitterAPI.Controller do
   end
 
   def favorite(%{assigns: %{user: user}} = conn, %{"id" => id}) do
-    with {:ok, status} <- TwitterAPI.fav(user, id) do
-      json(conn, status)
+    with {:ok, activity} <- TwitterAPI.fav(user, id) do
+      render(conn, ActivityView, "activity.json", %{activity: activity, for: user})
     end
   end
 
   def unfavorite(%{assigns: %{user: user}} = conn, %{"id" => id}) do
-    with {:ok, status} <- TwitterAPI.unfav(user, id) do
-      json(conn, status)
+    with {:ok, activity} <- TwitterAPI.unfav(user, id) do
+      render(conn, ActivityView, "activity.json", %{activity: activity, for: user})
     end
   end
 
   def retweet(%{assigns: %{user: user}} = conn, %{"id" => id}) do
-    with {:ok, status} <- TwitterAPI.repeat(user, id) do
-      json(conn, status)
+    with {:ok, activity} <- TwitterAPI.repeat(user, id) do
+      render(conn, ActivityView, "activity.json", %{activity: activity, for: user})
     end
   end