diff options
author | Ariadne Conill <ariadne@dereferenced.org> | 2019-07-18 15:06:58 +0000 |
---|---|---|
committer | Ariadne Conill <ariadne@dereferenced.org> | 2019-07-18 15:11:21 +0000 |
commit | 88d064d80e4a3272a2a7101089b5f924fd175866 (patch) | |
tree | 27510d4c7006b3058693159137fd4ce22dd1b7ae /test | |
parent | f9a0014681a2054ca9fec9df4729bce8bc0b4060 (diff) | |
download | pleroma-88d064d80e4a3272a2a7101089b5f924fd175866.tar.gz |
http signature plug: remove redundant checks handled by HTTPSignatures library
the redundant checks assumed a POST request, which will not work for signed GETs.
this check was originally needed because the HTTPSignatures adapter assumed that
the requests were also POST requests. but now, the adapter has been corrected.
Diffstat (limited to 'test')
-rw-r--r-- | test/plugs/http_signature_plug_test.exs | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/test/plugs/http_signature_plug_test.exs b/test/plugs/http_signature_plug_test.exs index efd811df7..d6fd9ea81 100644 --- a/test/plugs/http_signature_plug_test.exs +++ b/test/plugs/http_signature_plug_test.exs @@ -26,22 +26,4 @@ defmodule Pleroma.Web.Plugs.HTTPSignaturePlugTest do assert called(HTTPSignatures.validate_conn(:_)) end end - - test "bails out early if the signature isn't by the activity actor" do - params = %{"actor" => "https://mst3k.interlinked.me/users/luciferMysticus"} - conn = build_conn(:get, "/doesntmattter", params) - - with_mock HTTPSignatures, validate_conn: fn _ -> false end do - conn = - conn - |> put_req_header( - "signature", - "keyId=\"http://mastodon.example.org/users/admin#main-key" - ) - |> HTTPSignaturePlug.call(%{}) - - assert conn.assigns.valid_signature == false - refute called(HTTPSignatures.validate_conn(:_)) - end - end end |